Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual_relation timeout #175

Merged
merged 3 commits into from Nov 19, 2019
Merged

Fix visual_relation timeout #175

merged 3 commits into from Nov 19, 2019

Conversation

vincentschen
Copy link
Member

@vincentschen vincentschen commented Nov 19, 2019 •
edited

Description of proposed changes

  • Fix CI timeout for visual_relation by adding an additional echo before downloading dataset

Test plan

  • Existing CI passes

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have verified that my changes are covered by continuous integration.
  • All new and existing tests passed.

@vincentschen vincentschen marked this pull request as ready for review November 19, 2019 08:59
@vincentschen vincentschen requested a review from a team November 19, 2019 08:59
@vincentschen vincentschen changed the title Add travis wait for long-running nb tests Fix visual_relation timeout Nov 19, 2019
@vincentschen vincentschen merged commit 2ec715f into master Nov 19, 2019
@vincentschen vincentschen deleted the travis-wait branch November 19, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paroma paroma paroma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincentschen @paroma