Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker build #38

Merged
merged 8 commits into from Jul 29, 2019
Merged

Add Docker build #38

merged 8 commits into from Jul 29, 2019

Conversation

henryre
Copy link
Member

@henryre henryre commented Jul 28, 2019

Adds a container service for running tutorial notebooks. Instructions added to README.

Reviewers: please test it out for yourselves! Run on a few tutorials, try to break it!

Test plan
Tested on spam and crowdsourcing. There's currently no CI setup, we can discuss later.

@henryre henryre marked this pull request as ready for review July 29, 2019 03:52
@henryre henryre requested a review from a team July 29, 2019 03:54
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vincentschen
Copy link
Member

Re: conversation:

  • Silent failure on port if running another jupyter notebook on 8888
  • Check for missing docker install fails

Copy link
Member

@vincentschen vincentschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brahmaneya brahmaneya self-requested a review July 29, 2019 20:18
@henryre henryre merged commit 178764f into master Jul 29, 2019
@henryre henryre deleted the docker branch July 29, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants