New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate download scripts, feedback session #55
Conversation
paroma
commented
Aug 8, 2019
- Separate download scripts into full VRD and sample version
- Add content to clarify sample dataset form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! this will make it much cleaner. :)
TRAIN_DIR = "scene_graph/data/VRD/sg_dataset/samples" | ||
else: | ||
TRAIN_DIR = "scene_graph/data/VRD/sg_dataset/sg_train_images" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be cleaner:
TRAIN_DIR = "scene_graph/data/VRD/sg_dataset/samples" if sample else "scene_graph/data/VRD/sg_dataset/sg_train_images"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the line becomes too long and then looks odd sadly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, approving to unblock! 🚢
stacked with #66 |
* First rev on lighter-weight intro tutorial * Fixing @brahmaneya edits in PR * Editing down code to minimal form as suggested by HE * Simplifying code; adding TF example; editing * Editing pass over text * Transfer tags w jupytext build, minor edits * Filtering abstain values * Added a stub for SFs * Trying to fix style check * Skipping env_* files in flake * Style fixes * PR changes requested by @henryre * Quieting nltk output * Moved to getting_started * Silencing LogReg warning * Forgot to sync style fix... * Spelling fix * Addressing comments * First rev on lighter-weight intro tutorial * Fixing @brahmaneya edits in PR * Hot fix LF names (#63) * Mtl updates (#41) * [EASY] Update Scorer import paths (#58) * Save MTL updates in progress * Give more API hints * More text updates * Hide unnecessary helpers in utils * Drop unused import and sync notebook * Save MTL updates in progress * Give more API hints * More text updates * Hide unnecessary helpers in utils * Drop unused import and sync notebook * Address comments * Rename mtl to multitask so file and tutorial match * Update Scorer import paths * Update names of loss and output funcs * Update name of ce_loss_from_outputs() * Rename SnorkelClassifier to MultitaskClassifier (#59) * Update Scorer import * Update Scorer import in vrd_tutorial * Remove unused import * [EASY] Add links to RTD in multitask tutorial (#65) * Add links to RTD in multitask tutorial * Separate sentences * Sync multitask.ipynb * Editing down code to minimal form as suggested by HE * Add Drybell tutorial (#62) * Add drybell tutorial * Add to tox and README * Install Java on Travis * Pass JAVA_HOME * Add README * Update API * Revisions to crowdsourcing tutorial (#64) * Revisions to crowdsourcing tutorial * Run tox * Address comments * Simplifying code; adding TF example; editing * Recsys novel (#61) * Recsys first commit * Backup * Added second version * Recsys modeling work * Add review processing and LFs. * First complete draft * typo * Add ipynb * Add comments, refactor * Address comments * Updated ipynb * Update tox.ini to allow sync / test for recsys (but not by default) * Address comments * Update ipynb * Address final comments * Fix determinism of TF tutorial (#67) * Fix determinism of TF tutorial * Add os PYTHONGHASHSEED back * Editing pass over text * Transfer tags w jupytext build, minor edits * Filtering abstain values * Added a stub for SFs * Trying to fix style check * Skipping env_* files in flake * Style fixes * PR changes requested by @henryre * Quieting nltk output * Separate download scripts, feedback session (#55) * Moved to getting_started * Silencing LogReg warning * Slicing spam (#18) * Forgot to sync style fix... * Add link checking (#72) * Add link checking * Fix * Only run Travis on changed tutorials (#74) * Only run Travis on changed tutorials * Fix * Address comments * Fix * Fix a couple links (#75) * Fix link * Fix links * Fix Travis branch check (#77) * Spelling fix * Stop training on dev set [EASY] (#71) * Stop training on dev set * Update image link * Add style to run envs (#78) * Add style to run envs * Simplify * Make travis faster for spouse [EASY] (#80) * Make travis faster for spouse * remove extra cell * sync * all caps for constant * More verbose build script (#81) * Add markdown build mode (#79) * Add markdown build mode * Fix kwarg * Be a bit more opinionated * [EASY] Update path to snorkel to reflect ownership transfer (#82) * Update path to snorkel to reflect ownership transfer * Restore path to snorkel-superglue on HazyResearch * Make travis only run on changed dirs (#85) * Make travis only run on changed dirs * Small fix * Add space * Update tutorials with MultitaskClassifier API changes (#68) * Update multitask and scene_graph to last_op * Update spam tutorial * Update notebooks * Sync visual_relation notebook * Update spam notebooks * Run tox -e fix * Remove unused import * Configure markdown generation (#87) * Configure markdown generation * Add comments * [EASY] Replace `mtl` with `multitask` in README (#83) * Deploy tutorial pages via Travis (#88) * Deploy tutorial pages via Travis * Fix commands * Update readme (#73) * Update readme * Address comment * Addressing comments