Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gh workflow to close stale issues and PRs #1429

Merged
merged 3 commits into from
Aug 26, 2019
Merged

Conversation

vincentschen
Copy link
Member

Description of proposed changes

Add github workflow to close stale prs/issues: https://github.com/actions/stale

Test plan

Will check monitor workflow after it is deployed; does not affect core package

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentschen vincentschen requested review from a team and henryre August 25, 2019 17:35
@vincentschen
Copy link
Member Author

ping @henryre for visibility because you've configured other github workflows

@henryre
Copy link
Member

henryre commented Aug 25, 2019

what's the deal with help wanted issues? also do we need to run this every hour? feels like a bad use of fossil fuels

@vincentschen
Copy link
Member Author

what's the deal with help wanted issues?

The issue is picking up momentum :) Until then, we can trivially remove the stale label. I'd vote to ship this first to make sure we like the workflow.

also do we need to run this every hour? feels like a bad use of fossil fuels

This was the default; happy to change to daily or even weekly. That said, there are probably higher-leverage ways to save the earth...

❌ ⛏

@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #1429 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          55       55           
  Lines        1996     1996           
  Branches      327      327           
=======================================
  Hits         1947     1947           
  Misses         22       22           
  Partials       27       27

@henryre
Copy link
Member

henryre commented Aug 26, 2019

@vincentschen awesome! and it was more about it consuming runs. let's switch to daily: 0 12 * * *

Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@vincentschen
Copy link
Member Author

@vincentschen awesome! and it was more about it consuming runs. let's switch to daily: 0 12 * * *

got it! didn't realize it worked that way

@vincentschen vincentschen merged commit 591d568 into master Aug 26, 2019
@vincentschen vincentschen deleted the github_action_stale branch August 26, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants