Remove fault tolerant mode from LF/SF #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 97.64% 97.65% +0.01%
==========================================
Files 56 56
Lines 2078 2093 +15
Branches 334 336 +2
==========================================
+ Hits 2029 2044 +15
Misses 22 22
Partials 27 27
|
brahmaneya
approved these changes
Oct 2, 2019
test/labeling/lf/test_core.py
Outdated
| return 0 if x.num > 42 else -1 | ||
| db = [3, 6, 43] | ||
|
|
||
| @labeling_function(name="my_lf", resources=dict(db=db)) |
There was a problem hiding this comment.
Test a preprocessor here as well, since its one of the args
bhancock8
approved these changes
Oct 2, 2019
henryre
added a commit
that referenced
this pull request
Oct 11, 2019
* Remove fault tolerant mode from LF/SF * Add fault tolerance to appliers (#1480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Stacked with #1480
Remove the
fault_tolerantargument from LF/SF definition. This should be specified at apply time, rather than in the LF/SF definition itself. This change also allows us to track e.g. the number of times each LF fails.Test plan
Remove relevant tests