Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper bound networkx version at 2.4 #1492

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Upper bound networkx version at 2.4 #1492

merged 2 commits into from
Oct 16, 2019

Conversation

bhancock8
Copy link
Member

Description of proposed changes

Upper bound the version of networkx at 2.4 instead of 3.0, following the discovery of backwards incompatibility described in #1491.

Fixes #1491

Test plan

Regular unit tests pass.

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #1492 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1492   +/-   ##
======================================
  Coverage    97.6%   97.6%           
======================================
  Files          55      55           
  Lines        2049    2049           
  Branches      335     335           
======================================
  Hits         2000    2000           
  Misses         22      22           
  Partials       27      27

Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backwards-incompatible (2.3 -> 2.4) update to networkx
2 participants