Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU option for spaCy preprocessor #1523

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Add GPU option for spaCy preprocessor #1523

merged 1 commit into from
Dec 2, 2019

Conversation

henryre
Copy link
Member

@henryre henryre commented Dec 2, 2019

Description of proposed changes

Credit to @rjurney. Adds optional GPU mode for spaCy preprocessor.

Test plan

Previously tested by @rjurney, plus existing tests

@henryre henryre requested a review from a team December 2, 2019 02:53
Copy link
Member

@vincentschen vincentschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚢

@vincentschen
Copy link
Member

after tests pass, ofc

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1523 into master will decrease coverage by 0.09%.
The diff coverage is 60%.

@@            Coverage Diff            @@
##           master    #1523     +/-   ##
=========================================
- Coverage    97.6%   97.51%   -0.1%     
=========================================
  Files          55       55             
  Lines        2047     2052      +5     
  Branches      337      338      +1     
=========================================
+ Hits         1998     2001      +3     
- Misses         22       23      +1     
- Partials       27       28      +1
Impacted Files Coverage Δ
snorkel/labeling/lf/nlp.py 100% <100%> (ø) ⬆️
snorkel/preprocess/nlp.py 86.66% <33.33%> (-13.34%) ⬇️

@henryre henryre merged commit c469258 into master Dec 2, 2019
@henryre henryre deleted the spacy-gpu branch December 2, 2019 19:21
@henryre henryre mentioned this pull request Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants