Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --disable-example #13

Closed
wants to merge 1 commit into from
Closed

add --disable-example #13

wants to merge 1 commit into from

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented Jun 19, 2021

Add --disable-example to be able to build daq on toolchains without threads support

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Add --disable-example to be able to build daq on toolchains without
threads support

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@snortadmin
Copy link
Contributor

This is to avoid a pthread dependency? Threading is kinda fundamental to the mission. What are you doing that you can't / won't provide the dependency?

@ffontaine
Copy link
Contributor Author

The build failure is raised by buildroot autobuilders because all kind of embedded toolchains are tested and some of them can be built without threads support (e.g. uclibc). From my understanding of daq code, threads are only mandatory with pcap module and with this example but I can add a dependency to threads on daq if you think that this is best course of action.

@ffontaine
Copy link
Contributor Author

Should I close this PR and disable daq on toolchains without threads on buildroot?

@snortadmin
Copy link
Contributor

I think we want to do something for those toolchains. Not sure we should just change it to --disable-threads or do some autodetect foo.

@Xiche - thoughts?

@Xiche
Copy link
Contributor

Xiche commented Jul 7, 2021

Looks reasonable to me like this. Autoconf checks for threading seems too special case to be worth it, but a switch to disable the examples seems reasonable.

@ffontaine
Copy link
Contributor Author

ffontaine commented Jul 27, 2021

Finally, I'm closing this PR as I found out that afpacket and bpf modules also depend on threads if libpcap is found. So, I'll had a threads dependency in buildroot.

@ffontaine ffontaine closed this Jul 27, 2021
@snortadmin
Copy link
Contributor

Thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants