Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some good security practices #40

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bordenit
Copy link

  1. Don't run as root.
  2. Apply securityContext
  3. If it works, I can trust using your container more as it's forced to not run as root in more ways than 1.

@cmoulliard
Copy link
Member

3. If it works, I can trust using your container more as it's forced to not run as root in more ways than 1.

Have you tested on your cluster the change you propose (= dockerfile and helm's deploy manifest) ? @bordenit

Remark: Many thanks to propose a PR ;-)

@cmoulliard
Copy link
Member

Have you tested on your cluster the change you propose (= dockerfile and helm's deploy manifest) ? @bordenit

@bordenit
Copy link
Author

bordenit commented Feb 14, 2024

Sorry for the delay, yeah I built my own container from your Dockerfile and use these settings in my Kubernetes deployment. It has been running fine since I submitted the PR. Mainly use this at home for internal applications with Nginx.

@cmoulliard
Copy link
Member

Some documentation and Helm changes are needed in order to tell the user that, for security reason, we don't run as root anymore the container, that UID/GUID could be pass as ARG to the docker build and should be, of course, overridden using the Helm chart, etc @bordenit

@cmoulliard
Copy link
Member

Some documentation and Helm changes are needed in order to tell the user that, for security reason, we don't run as root anymore the container, that UID/GUID could be pass as ARG to the docker build and should be, of course, overridden using the Helm chart, etc @bordenit

Can you have a look please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants