Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to make the project compatible with Java 8 #12

Closed
fatiiates opened this issue Jul 17, 2021 · 2 comments
Closed

Is it possible to make the project compatible with Java 8 #12

fatiiates opened this issue Jul 17, 2021 · 2 comments

Comments

@fatiiates
Copy link
Contributor

fatiiates commented Jul 17, 2021

I am developing Jenkins Pipeline(DSL) Plugin for Buildpacks. I'm thinking of performing processes with this client. But Jenkins plugins cannot currently work with Java 11. Jenkins plugins support Java 8 and below.

Is it possible to make the project compatible with Java 8 ?

@fatiiates fatiiates changed the title Rule 3: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: Found Banned Dependency: com.github.snowdrop:java-buildpack-client:jar:main-a8a9928e4a-1 Is it possible to make the project compatible with Java 8 Jul 17, 2021
@BarDweller
Copy link
Collaborator

It may be as simple as changing the level in the pom.xml .. I'd need to try.. Java 8 is kinda old now tho! I'm not sure if I used any post 8 features within the code, or what level the dependencies would ask for. If you have time, fork and give it a go, and let me know how it goes! .. I'm not able to get back to this code for a few weeks yet, so you'll probably get an answer quicker if you have a bash yourself =)

@fatiiates
Copy link
Contributor Author

Thanks, I was able to get it working with java 8. Just one line change in "docker/ContainerUtils.java" was enough.

// docker/ContainerUtils.java  
// IOUtils class comes from org.apache.commons.io.IOUtils  
IOUtils.copy(is, tout);  
// As far as I understand, method "transferTo()"  in line "is.transferTo(tout);"  comes with Java 9.

If it works for you, it is currently in my own repository as a local maven repository.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants