Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding required spring framework/cloud deps that were missing w.r.t Brewery App #10

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

kameshsampath
Copy link
Contributor

No description provided.

@kameshsampath
Copy link
Contributor Author

@cmoulliard - wondering we should use

 <dependency>
        <groupId>org.springframework.cloud</groupId>
        <artifactId>spring-cloud-dependencies</artifactId>
        <version>${spring-cloud.version}</version>
        <scope>import</scope>
        <type>pom</type>
      </dependency>

      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-dependencies</artifactId>
        <version>${spring-boot.version}</version>
        <scope>import</scope>
        <type>pom</type>
      </dependency>

Instead of having each individual projects defined in the BOM - thoughts ?

@pavolloffay
Copy link

I think x-dependencies is better from the maintenance perspective (if we are going to use the same versions as original SB stack)

@kameshsampath
Copy link
Contributor Author

kameshsampath commented Sep 1, 2017

thanks @pavolloffay , I shall make the needed updates, test it locally , add that commit to this PR

@pavolloffay
Copy link

It's not my call, however, I used that in OpenTracing integrations.

@kameshsampath
Copy link
Contributor Author

@cmoulliard thoughts ???

@cmoulliard
Copy link
Member

cmoulliard commented Sep 4, 2017

@kameshsampath Can you rebase as there is a conflict and submit a commit with all your changes ?

@kameshsampath kameshsampath changed the base branch from master to sb-1.5.x September 5, 2017 03:50
@kameshsampath
Copy link
Contributor Author

@cmoulliard - I am sorry, that I had sent the PR to the master instead of sb-1.5.x branch of upstream, corrected my pull. please verify and let me know if any updates required.

Also any thoughts on using Spring BOM's instead of explicit dependencies ??

@cmoulliard cmoulliard merged commit ffa4f50 into snowdrop:sb-1.5.x Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants