[SB-332] Add Arquillian dependency #2
Conversation
|
Let's wait until I tag the boosters for GA before using it ;) |
|
ok |
| @@ -89,28 +98,13 @@ | |||
| <resource> | |||
| <directory>src/main/resources</directory> | |||
| <filtering>true</filtering> | |||
| <includes> | |||
There was a problem hiding this comment.
Why did you remove these? I thought that it was maybe better to list explicitly which files we're filtering, though, granted, it is a little more difficult with the new Cube capability to use maven-like properties in annotations.
There was a problem hiding this comment.
Some boosters have specific files such as keycloak.json, arquillian.xml etc. I think it should be safe to filter all files for the majority of the boosters. It would be quite hard to maintain the full list of inclusions.
There was a problem hiding this comment.
We can always exclude files in the boosters if we see an issue, but so far there were issues with not included patters only.
https://issues.jboss.org/browse/SB-332
@metacosm I think once this is merged we should be ok to tag v1 and start using it.