Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-747364: Why are dependencies vendored? #729

Closed
judahrand opened this issue Feb 21, 2023 · 4 comments
Closed

SNOW-747364: Why are dependencies vendored? #729

judahrand opened this issue Feb 21, 2023 · 4 comments
Labels
enhancement The issue is a request for improvement or a new feature question Issue is a usage/other question rather than a bug

Comments

@judahrand
Copy link
Contributor

judahrand commented Feb 21, 2023 •
edited
Loading

Issue description

What is the rationale for vendoring dependencies?

Can we move away from vendored dependencies so that this driver can be more easily used in other projects?
@github-actions github-actions bot changed the title Why are dependencies vendored? SNOW-747364: Why are dependencies vendored? Feb 21, 2023
@judahrand
Copy link
Contributor Author

@sfc-gh-ext-simba-lb ?

@sfc-gh-dszmolka
Copy link
Contributor

thank you for opening this request ! we'll consider it - can't promise any timeline though when it will be picked up, so thank you for bearing with us !

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature question Issue is a usage/other question rather than a bug labels Mar 29, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Apr 18, 2023
Merged
6 tasks
@sfc-gh-dszmolka
Copy link
Contributor

#776 merged into main

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label May 10, 2023
@sfc-gh-dszmolka
Copy link
Contributor

fix released with version 1.6.21, closing this issue

@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is a request for improvement or a new feature question Issue is a usage/other question rather than a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@judahrand @sfc-gh-dszmolka