-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: Ignore vendor
directory
#776
Conversation
I have read the CLA Document and I hereby sign the CLA |
recheck |
@sfc-gh-dszmolka any chance of review/running the workflows? |
PRs posted in this repo are regularly reviewed by the driver team, cannot promise any estimated timeline though. Thank you for bearing with us ! |
could you please add more details about this PR? |
Hi @sfc-gh-igarish! The reasoning could be linked to #729. Basically, it's not required to save the Additionally, having this lot of files results in huge updates when it should've been only a small commit. |
I agree with this personally! It will make updates of dependencies significantly easier going forward if we can get rid of the vendor directory entirely. |
@sfc-gh-igarish is there a chance to get this reviewed/merged? |
I have read the CLA Document and I hereby sign the CLA |
Hi @sfc-gh-igarish! Any chance on reviewing this? |
@candiduslynx they will probably ask you to rebase this back up-to-date. So can you pre-emptively do that and let's hope we can get their attention 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sfc-gh-igarish thanks for the review! |
Let's wait. I will let you know. |
Description
Please explain the changes you made here.
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them