Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-747896: Looking at some memory consumption on a client code of the go library it seems that chunk 0 is freed only at the end #732

Closed
stephane-moreau opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
bug Erroneous or unexpected behaviour

Comments

@stephane-moreau
Copy link

Issue description

looking at file chunk_downloader.go, line 186

		scd.ChunksMutex.Lock()
		if scd.CurrentChunkIndex > 1 {
			scd.Chunks[scd.CurrentChunkIndex-1] = nil // detach the previously used chunk
		}

this leaves chunk of index 0 in the scd.Chunks map up until the end of the statement result processing

Shouldn't thie be changed to

		if scd.CurrentChunkIndex >= 1 {

Configuration

1.6.17

Go version: 1.18

@github-actions github-actions bot changed the title Looking at some memory consumption on a client code of the go library it seems that chunk 0 is freed only at the end SNOW-747896: Looking at some memory consumption on a client code of the go library it seems that chunk 0 is freed only at the end Feb 22, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Mar 29, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label Mar 29, 2023
@sfc-gh-dszmolka
Copy link
Contributor

hi, thank you for reporting this issue! we'll take a look.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-in_progress Issue is worked on by the driver team bug Erroneous or unexpected behaviour and removed status-triage Issue is under initial triage labels Mar 30, 2023
@sfc-gh-dszmolka
Copy link
Contributor

fixed by #772

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-in_progress Issue is worked on by the driver team status-pr_pending_merge A PR is made and is under review status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. labels Apr 12, 2023
@sfc-gh-dszmolka
Copy link
Contributor

fix released with 1.6.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

3 participants