SNOW-1222159 Download arrow batches even if first one is empty #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-1222159-first-arrow-batch-empty
branch
from
01c492f
to
618468d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
- Coverage 84.00% 84.00% -0.01%
==========================================
Files 50 50
Lines 9946 9944 -2
==========================================
- Hits 8355 8353 -2
Misses 1591 1591 ☔ View full report in Codecov by Sentry. |
sfc-gh-dheyman-1
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When first arrow batch (returned with query-request response) is empty, download of the remaining chunks does not start at all. This PR fixes this situation.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them