Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if the specified db, schema or warehouse doesn't exist #124

Merged
merged 2 commits into from
Nov 17, 2017

Conversation

smtakeda
Copy link
Contributor

Description

Fixed #110

This change will raise errors if the specified db, schema or warehouse doesn't exist at connection time. The role is already validated, so others should be too.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@smtakeda smtakeda self-assigned this Nov 17, 2017
@smtakeda
Copy link
Contributor Author

Also error code issue was fixed too. Somehow iota doesn't work to assign the continuous ids for errors but all were set to the same number...

@smtakeda smtakeda merged commit ac33a92 into master Nov 17, 2017
@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #124 into master will decrease coverage by 0.07%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   82.02%   81.94%   -0.08%     
==========================================
  Files          18       18              
  Lines        2359     2382      +23     
==========================================
+ Hits         1935     1952      +17     
- Misses        336      340       +4     
- Partials       88       90       +2
Impacted Files Coverage Δ
errors.go 78.57% <ø> (ø) ⬆️
auth.go 90.37% <100%> (ø) ⬆️
driver.go 77.77% <88.88%> (+2.48%) ⬆️
connection.go 75.33% <0%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6435aa6...fccd7bd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raise error if the specified db, schema or warehouse doesn't exist
2 participants