Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make port/portStr variables in cmd more consistent #801

Closed
wants to merge 1 commit into from
Closed

Make port/portStr variables in cmd more consistent #801

wants to merge 1 commit into from

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented May 25, 2023 •
edited

Description

There were some inconsistency in setting up port used to connect to Snowflake from example apps.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner May 25, 2023 11:07
@sfc-gh-pfus sfc-gh-pfus mentioned this pull request May 25, 2023
Merged
6 tasks
@sfc-gh-pfus sfc-gh-pfus deleted the port branch June 1, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sfc-gh-pfus