Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-829454: Async API Example #813

Merged
merged 6 commits into from
Jun 6, 2023
Merged

SNOW-829454: Async API Example #813

merged 6 commits into from
Jun 6, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Prepare Async API example.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner June 2, 2023 07:47
@github-actions
Copy link

github-actions bot commented Jun 2, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-pbulawa
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-pfus
sfc-gh-pfus reviewed Jun 2, 2023
View reviewed changes
cmd/async/async.go Show resolved Hide resolved
cmd/async/async.go Outdated Show resolved Hide resolved
cmd/async/async.go Outdated Show resolved Hide resolved
sfc-gh-dheyman-1
sfc-gh-dheyman-1 reviewed Jun 2, 2023
View reviewed changes
cmd/async/async.go Outdated Show resolved Hide resolved
sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 2f493c8 into master Jun 6, 2023
23 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the 418-snow-829454-async-api-example branch June 6, 2023 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sfc-gh-pbulawa @sfc-gh-igarish @sfc-gh-dheyman-1 @sfc-gh-pfus