SNOW-829468: Add null checks before accessing connection config during chunk downloading #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (sc *snowflakeConn) stopHeartBeat() { | ||
| if !sc.isClientSessionKeepAliveEnabled() { | ||
| if sc.cfg != nil && !sc.isClientSessionKeepAliveEnabled() { |
There was a problem hiding this comment.
again why checks for sc.cfg != nil?
There was a problem hiding this comment.
same as above.
sfc-gh-pfus
reviewed
Jun 14, 2023
move sc.rest nil check
sfc-gh-ext-simba-lb
force-pushed
the
addNullChecksForConnectionConfig
branch
from
4e39ad3
to
a06a3e7
Compare
sfc-gh-pfus
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a connection is cancelled, it is cleaned up by the cleanup() function. This sets the sc.cfg and sc.rest to nil. It could happen that a chunk is downloaded before cancel but decoded after. As seen in customer issue https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/420
This PR is to add checks where the sc.cfg and sc.rest are accessed in this scenario to avoid nil pointer dereference during chunk downloading if the connection is cancelled.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them