Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-645253 Handle binding named parameters #850

Merged
merged 1 commit into from
Jul 18, 2023
Merged

SNOW-645253 Handle binding named parameters #850

merged 1 commit into from
Jul 18, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jul 17, 2023 •
edited
Loading

Description

Fixes https://snowflakecomputing.atlassian.net/browse/SNOW-645253 / #644
Binding does not work for two cases (date/time) - but it doesn't work for any times of binding, not just for named parameters. Need to investigate it further, will provide solution in another PR.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner July 17, 2023 07:51
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-645253-bind-named-parameters branch from 0c24045 to 26f0792 Compare July 17, 2023 07:53
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Jul 17, 2023
Closed
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jul 17, 2023
View reviewed changes
bindings_test.go Outdated Show resolved Hide resolved
bindings_test.go Show resolved Hide resolved
bindings_test.go Outdated Show resolved Hide resolved
bindings_test.go Outdated Show resolved Hide resolved
bindings_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-645253-bind-named-parameters branch 3 times, most recently from 78ddbd2 to 0f70cb5 Compare July 17, 2023 10:43
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-645253-bind-named-parameters branch from 0f70cb5 to 85ea3dc Compare July 18, 2023 05:09
@sfc-gh-pfus sfc-gh-pfus merged commit 67ec6cf into master Jul 18, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-645253-bind-named-parameters branch July 18, 2023 05:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-dheyman-1