SNOW-540086: cover critical areas test code coverage for logger, dsn and connection #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-lb
force-pushed
the
increaseLoggerCoverage
branch
from
3168c62
to
ec02780
Compare
sfc-gh-ext-simba-lb
force-pushed
the
increaseLoggerCoverage
branch
from
ec02780
to
d37b153
Compare
sfc-gh-pfus
reviewed
Jul 31, 2023
| if err = authenticateWithConfig(sc); err != nil { | ||
| t.Error(err) | ||
| } | ||
| tx, _ := sc.Begin() |
There was a problem hiding this comment.
Shouldn't we close a transaction here?
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| sc, err := buildSnowflakeConn(ctx, *config) |
There was a problem hiding this comment.
Shouldn't we call Close at the end?
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| sc, err := buildSnowflakeConn(ctx, *config) |
There was a problem hiding this comment.
Shouldn't we call Close at the end?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase log.go coverage to 82.7% and cover missing critical areas in dsn.go and connection.go.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them