Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-540086: Increase code coverage on converter.go #867

Merged
merged 2 commits into from
Aug 1, 2023
Merged

SNOW-540086: Increase code coverage on converter.go #867

merged 2 commits into from
Aug 1, 2023

Conversation

sfc-gh-ext-simba-lb
Copy link
Contributor

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb commented Jul 28, 2023 •
edited
Loading

Description

Increase code coverage for converter.go to 92.0% to cover critical areas missed.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb requested a review from a team as a code owner July 28, 2023 23:08
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb force-pushed the increaseCodeCoverageOnCoverter branch 2 times, most recently from 2c0d05c to 3e09395 Compare July 31, 2023 15:15
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb merged commit 856123c into master Aug 1, 2023
23 checks passed
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb deleted the increaseCodeCoverageOnCoverter branch August 1, 2023 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-ext-simba-lb @sfc-gh-igarish @sfc-gh-pfus