Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-880396: Do not cancel other matrix builds when one fails #870

Merged
merged 2 commits into from
Aug 1, 2023
Merged

SNOW-880396: Do not cancel other matrix builds when one fails #870

merged 2 commits into from
Aug 1, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

  • Do not cancel other matrix builds when one fails
  • Cancel build when new code in branch appears

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner August 1, 2023 10:39
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 4034084 into master Aug 1, 2023
23 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-880396-do-not-cancel-other-matrix-builds-when-one-fails branch August 1, 2023 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-dprzybysz @sfc-gh-pmotacki @sfc-gh-pfus