SNOW-540086 Code coverage: Refactor unused function downloadFilesSequentially() #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When executing a command the fileTransferAgent checks the srcFileSize and assigns it to either large or small file metadata. Large file metadata is uploaded/downloaded sequentially while small file metadata is uploaded/downloaded in parallel.
However, the srcFileSize for downloading is always 0, since we don't yet know the file size in the stage. So when it hits this block, it will always be added to small file metadata and then downloaded in parallel.
This PR is to remove the unused function.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them