Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-857660: Init rows location once #882

Merged
merged 1 commit into from
Aug 11, 2023
Merged

SNOW-857660: Init rows location once #882

merged 1 commit into from
Aug 11, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Aug 9, 2023 •
edited
Loading

Description

Initialize location once per query, instead of creating it for each row and column.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review August 9, 2023 08:53
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 9, 2023 08:53
sfc-gh-dstempniak
sfc-gh-dstempniak reviewed Aug 9, 2023
View reviewed changes
location_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-857660-improve-json-v2 branch 2 times, most recently from 1105d9f to 73bbd11 Compare August 9, 2023 12:21
@sfc-gh-pfus sfc-gh-pfus mentioned this pull request Aug 11, 2023
Closed
6 tasks
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 5e4e7e1 into master Aug 11, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-857660-improve-json-v2 branch August 11, 2023 07:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-dstempniak