Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-895534: Add HTAP query context struct #888

Merged
merged 1 commit into from
Aug 24, 2023
Merged

SNOW-895534: Add HTAP query context struct #888

merged 1 commit into from
Aug 24, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Aug 18, 2023 •
edited
Loading

Description

Provided query context structs and tests for serialisation and deserialisation.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 18, 2023 10:31
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Aug 18, 2023
View reviewed changes
htap.go Show resolved Hide resolved
htap.go Show resolved Hide resolved
htap_test.go Outdated Show resolved Hide resolved
htap_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-serde-query-context branch 3 times, most recently from 53e2e56 to 1b7b850 Compare August 18, 2023 10:48
@sfc-gh-pfus sfc-gh-pfus changed the title SNOW-895534: Add HTAP query context structs SNOW-895534: Add HTAP query context struct Aug 18, 2023
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-serde-query-context branch from 1b7b850 to 1222a2d Compare August 21, 2023 07:11
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-serde-query-context branch from 1222a2d to 2a5e435 Compare August 23, 2023 05:55
@sfc-gh-pfus sfc-gh-pfus merged commit b2103bc into master Aug 24, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-895534-serde-query-context branch August 24, 2023 05:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pbulawa