Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-889572 Refactored snowflake type implementation to map #890

Merged
merged 6 commits into from
Aug 24, 2023
Merged

SNOW-889572 Refactored snowflake type implementation to map #890

merged 6 commits into from
Aug 24, 2023

Conversation

sfc-gh-dheyman-1
Copy link
Collaborator

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 commented Aug 21, 2023 •
edited
Loading

Description

Resolves #881
This PR introduces map as a snowflake type storage structure to make lookups more efficient.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 requested a review from a team as a code owner August 21, 2023 13:13
@sfc-gh-pbulawa
Copy link
Collaborator

Could you please update the PR description?

@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Aug 21, 2023
Closed
sfc-gh-pfus
sfc-gh-pfus reviewed Aug 22, 2023
View reviewed changes
datatype.go Outdated Show resolved Hide resolved
datatype.go Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Aug 22, 2023
View reviewed changes
datatype.go Outdated Show resolved Hide resolved
@sfc-gh-dheyman-1 sfc-gh-dheyman-1 merged commit 18daec5 into master Aug 24, 2023
23 checks passed
@sfc-gh-dheyman-1 sfc-gh-dheyman-1 deleted the SNOW-889572-getSnowlakeType-map-refactor branch August 24, 2023 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getSnowflakeType() could be more efficient
3 participants
@sfc-gh-dheyman-1 @sfc-gh-pbulawa @sfc-gh-pfus