Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-726742 Remove queryID from snowflakeConn #892

Merged
merged 1 commit into from
Aug 24, 2023
Merged

SNOW-726742 Remove queryID from snowflakeConn #892

merged 1 commit into from
Aug 24, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Aug 23, 2023 •
edited

Description

QueryID was persisted in snowflakeConn and read by some functions. It could cause race conditions if the same connection is reused among threads. Now, the queryId is read from the responses.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-726742-remove-query-id-from-snowflake-conn branch from 380ef07 to 979c2ed Compare August 23, 2023 10:21
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review August 23, 2023 11:04
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 23, 2023 11:04
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-726742-remove-query-id-from-snowflake-conn branch 2 times, most recently from 25beaf4 to 7f60660 Compare August 23, 2023 11:15
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-726742-remove-query-id-from-snowflake-conn branch from 7f60660 to a23e7be Compare August 24, 2023 06:11
@sfc-gh-pfus sfc-gh-pfus merged commit 190c9ca into master Aug 24, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-726742-remove-query-id-from-snowflake-conn branch August 24, 2023 06:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-pfus @sfc-gh-dprzybysz