Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-969837: Use macos-11 for tests #975

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Nov 28, 2023

Description

Use macos-11 for the tests as macos-12 and macos-13 have a time shift bug.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f33dfc7) 82.80% compared to head (ac85d31) 82.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          50       50           
  Lines        9643     9643           
=======================================
  Hits         7985     7985           
  Misses       1658     1658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-969837: Test TestJWTAuthentication SNOW-969837: Use macos-11 for tests Nov 29, 2023
@sfc-gh-pbulawa sfc-gh-pbulawa marked this pull request as ready for review November 29, 2023 12:01
@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner November 29, 2023 12:01
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 15fac29 into master Nov 29, 2023
25 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-969837-testjwtauthentication branch November 29, 2023 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants