Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-514684: Connection Caching support to reduce number of prompts for authentication? #236

Open
varun-dc opened this issue Dec 2, 2021 · 7 comments
Open

SNOW-514684: Connection Caching support to reduce number of prompts for authentication? #236

varun-dc opened this issue Dec 2, 2021 · 7 comments
Assignees
@sfc-gh-anugupta
Labels
enhancement The issue is a request for improvement or a new feature parity this feature is supported in other drivers status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team

Comments

@varun-dc
Copy link

varun-dc commented Dec 2, 2021 •
edited
Loading

Please answer these questions before submitting your issue. Thanks!

  1. What version of NodeJS are you using (node --version and npm --version)?
    node 16.x.x

  2. What operating system and processor architecture are you using?
    Linux x86_64, MacOS ARM

  3. What are the component versions in the environment (npm list)?
    snowflake-sdk@1.6.4

The docs state,

Snowflake supports connection caching with the following drivers and connectors on macOS and Windows (currently, this feature is not supported on Linux):

ODBC driver version 2.21.2 (or later)
JDBC driver version 3.12.8 (or later)
Snowflake Connector for Python 2.2.8 (or later)

But there is no support in the snowflake-connector-nodejs correct? Are there any plans to add support for connection caching in this package? If we submitted a pull request with this functionality, based on the work done in the python connector for example, will that be likely to be accepted into this package?
@sfc-gh-hchaturvedi sfc-gh-hchaturvedi added the parity this feature is supported in other drivers label Dec 2, 2021
@sfc-gh-sbommakanty sfc-gh-sbommakanty changed the title Connection Caching support to reduce number of prompts for authentication? SNOW-514684: Connection Caching support to reduce number of prompts for authentication? Dec 2, 2021
@sfc-gh-jfan sfc-gh-jfan reopened this Jul 1, 2022
@github-actions github-actions bot closed this as completed Jul 2, 2022
@sfc-gh-jfan sfc-gh-jfan reopened this Jul 6, 2022
@sfc-gh-dszmolka
Copy link
Collaborator

thank you for submitting this issue! since it's still relevant (the driver does not support connection caching today) i raised this within the team for someone to take a look and estimate the work needed. will post any updates here, once available (which might take a while so thank you in advance for bearing with us)

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-in_progress Issue is worked on by the driver team labels Mar 23, 2023
@jholm117
Copy link

jholm117 commented Aug 3, 2023

Hello! Is there any update on this feature?

@sfc-gh-dszmolka
Copy link
Collaborator

hi - at this moment, I'm unable to give any estimation, but syncing internally with the rest of the team and will share if there's any timelines visible. what I can say right now, that this item is definitely on the radar, just I cannot attach any estimation right now. thank you for bearing with us !

@hughess
Copy link

hughess commented Dec 7, 2023

+1 this would be a big help

@Elliot2718
Copy link

+1 I'm also interested in seeing this implemented

@sfc-gh-dszmolka
Copy link
Collaborator

thank you everyone for bearing with us while the feature gets implemented. there's some bumps still needing to be ironed out, but we're actively working on the implementation. will keep this thread posted.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Mar 12, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

sfc-gh-dszmolka commented Apr 15, 2024 •
edited
Loading

apologies it taking so long, but being an entirely new feature which on top of it, operates on user credentials, we also had to go through a (lengthy) internal security review before the actual implementation.

Feature PR's can be followed here:

As of now, I cannot give a specific ETA for the actual implementation, but syncing internally with the team and will update if there's any more specifics.

edit: there is - we aim to release both features in the April release cycle (happens usually towards end of given month) so fingers crossed !

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review and removed status-in_progress Issue is worked on by the driver team labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-anugupta sfc-gh-anugupta

Labels
enhancement The issue is a request for improvement or a new feature parity this feature is supported in other drivers status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@hughess @jholm117 @sfc-gh-hkapre @sfc-gh-hchaturvedi @Elliot2718 @sfc-gh-jfan @sfc-gh-dszmolka @varun-dc @sfc-gh-jhollan @sfc-gh-anugupta