Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-824882 SSO token cache #820

Merged
merged 84 commits into from
Jun 27, 2024
Merged

SNOW-824882 SSO token cache #820

merged 84 commits into from
Jun 27, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

  • Added id_token authentication
  • Added secureStorage feature
  • Added reauthentication

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner April 3, 2024 17:50
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 78.80795% with 32 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (03d557d) to head (8ca1118).

Files Patch % Lines
...tication/secure_storage/json_credential_manager.js 87.27% 7 Missing ⚠️
lib/services/sf.js 50.00% 7 Missing ⚠️
lib/connection/connection_config.js 68.75% 5 Missing ⚠️
lib/util.js 78.26% 5 Missing ⚠️
lib/connection/connection.js 60.00% 4 Missing ⚠️
lib/authentication/auth_idtoken.js 72.72% 3 Missing ⚠️
lib/core.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   89.20%   88.95%   -0.26%     
==========================================
  Files          62       64       +2     
  Lines        5947     6091     +144     
==========================================
+ Hits         5305     5418     +113     
- Misses        642      673      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/core.js Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
lib/global_config.js Outdated Show resolved Hide resolved
lib/services/sf.js Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
test/integration/testManualConnection.js Show resolved Hide resolved
Copy link

gitguardian bot commented Jun 19, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11748687 Triggered Generic High Entropy Secret 4d9b3d4 test/unit/file_transfer_agent/encrypt_util_test.js View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some problem during running manual test. It must be investigated.

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 8f0b0f6 into master Jun 27, 2024
45 of 49 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the idtoken branch June 27, 2024 03:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants