Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-702210: Node.js Connector => How to fetchAsString but keep null values #831

Merged
merged 36 commits into from
May 21, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Apr 29, 2024

Description

Please explain the changes you made here.

  • Added 'Null' option in the fetchAsString list. This change will be the BCR. If the customer wants to get the value 'null' as String 'NULL', they should add the 'NULL' in the fetchAsString option.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner April 29, 2024 02:29
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as draft April 29, 2024 02:29
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.24%. Comparing base (e80f3ea) to head (e4817eb).

Files Patch % Lines
lib/connection/connection_config.js 75.00% 1 Missing ⚠️
lib/connection/result/column.js 87.50% 1 Missing ⚠️
lib/connection/result/data_types.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   89.25%   89.24%   -0.02%     
==========================================
  Files          61       61              
  Lines        5892     5903      +11     
==========================================
+ Hits         5259     5268       +9     
- Misses        633      635       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Apr 29, 2024

@sfc-gh-ext-simba-jy Please add test cases to cover the use case of keeping old behavior.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a user May 2, 2024 19:15
test/unit/mock/mock_http_client.js Outdated Show resolved Hide resolved
lib/connection/result/data_types.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review May 6, 2024 16:25
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit eae29a7 into master May 21, 2024
46 of 48 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the fetchAsStringNull branch May 21, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants