-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-702210: Node.js Connector => How to fetchAsString but keep null values #831
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 89.25% 89.24% -0.02%
==========================================
Files 61 61
Lines 5892 5903 +11
==========================================
+ Hits 5259 5268 +9
- Misses 633 635 +2 ☔ View full report in Codecov by Sentry. |
@sfc-gh-ext-simba-jy Please add test cases to cover the use case of keeping old behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)