Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-370095 updated vendored libraries #764

Merged
merged 2 commits into from Jun 22, 2021
Merged

SNOW-370095 updated vendored libraries #764

merged 2 commits into from Jun 22, 2021

Conversation

sfc-gh-mkeller
Copy link
Collaborator

SNOW-370095
Updating our vendored libraries:

  • urllib to version 1.26.5
  • requests to version 2.25.1

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Jun 18, 2021
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-370095 updated urllib3 to 1.26.5 SNOW-370095 updated vendored libraries Jun 18, 2021
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-370095-update_vendored_libraries branch from 07abf1b to 78a0928 Compare June 19, 2021 01:01
@codecov-commenter
Copy link

Codecov Report

Merging #764 (78a0928) into master (4e10307) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   82.85%   82.99%   +0.14%     
==========================================
  Files          58       58              
  Lines        7464     7464              
  Branches     1123     1123              
==========================================
+ Hits         6184     6195      +11     
+ Misses        960      952       -8     
+ Partials      320      317       -3
Impacted Files Coverage Δ
src/snowflake/connector/errors.py 90.74% <0.00%> (-0.62%) ⬇️
src/snowflake/connector/telemetry_oob.py 77.90% <0.00%> (ø)
src/snowflake/connector/network.py 82.20% <0.00%> (+0.67%) ⬆️
src/snowflake/connector/ocsp_snowflake.py 73.73% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e10307...78a0928. Read the comment docs.

sfc-gh-hchaturvedi
sfc-gh-hchaturvedi approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sfc-gh-mkeller sfc-gh-mkeller merged commit 939c06b into master Jun 22, 2021
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-370095-update_vendored_libraries branch June 22, 2021 00:45
@jtcohen6 jtcohen6 mentioned this pull request Aug 13, 2021
Closed
sfc-gh-aling pushed a commit that referenced this pull request Oct 17, 2022
@sfc-gh-mkeller
SNOW-370095 updated vendored libraries (#764)
a348c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi sfc-gh-hchaturvedi approved these changes

@sfc-gh-kwagner sfc-gh-kwagner Awaiting requested review from sfc-gh-kwagner

Assignees

@sfc-gh-mkeller sfc-gh-mkeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-mkeller @codecov-commenter @sfc-gh-hchaturvedi