Remove RSA Public Key #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
binglihub
commented
Oct 19, 2018
binglihub
commented
- remove RSA public key requirement
- upgrade Jackson libs tp 2.9.6
- create integration test
howryu
reviewed
Oct 19, 2018
| KeyFactory kf = KeyFactory.getInstance("RSA"); | ||
|
|
||
| //generate public key from private key | ||
| RSAPrivateCrtKey privk = (RSAPrivateCrtKey) privateKey; |
There was a problem hiding this comment.
Throw proper user error in case user is passing in a PrivateKey not instancesof RSAPrivateCrtKey
There was a problem hiding this comment.
I added a checker
if(!(privateKey instanceof RSAPrivateCrtKey))
throw new IllegalArgumentException("Input private key is not a RSA private key");
howryu
reviewed
Oct 19, 2018
| * ingest test | ||
| */ | ||
| @Test | ||
| public void test1() throws Exception |
There was a problem hiding this comment.
Maybe a better name? testSimpleIngest?
howryu
reviewed
Oct 19, 2018
| @After | ||
| public void afterAll() | ||
| { | ||
| //System.out.println(111); |
howryu
reviewed
Oct 19, 2018
test_files/test1.csv
Outdated
| @@ -0,0 +1,3 @@ | |||
| "a",1 | |||
There was a problem hiding this comment.
Maybe add move test data to test resource directory? src/test/resource
howryu
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.