SNOW-830955 Use default SDK version in User-Agent #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lsembera
force-pushed
the
lsembera/wrong-version
branch
from
e126bc8
to
42ac697
Compare
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 74.88% 74.97% +0.08%
==========================================
Files 77 77
Lines 4771 4756 -15
Branches 419 418 -1
==========================================
- Hits 3573 3566 -7
+ Misses 1017 1010 -7
+ Partials 181 180 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-tjones
approved these changes
Jun 2, 2023
|
Thanks! Can you quickly validate the version number shows up as expected in snowhouse for the account you tested this change on: |
sfc-gh-rcheng
approved these changes
Jun 4, 2023
While constructing HTTP User-Agent header, take the SDK version from code instead from a file on classpath. It is less prone to accidental classpath overrides. The consequence of this is that we must now keep the DEFAULT_VERSION in sync with the project version defined in Maven, which we are doing already anyway (a new test has been added to verify this).
sfc-gh-lsembera
force-pushed
the
lsembera/wrong-version
branch
from
42ac697
to
a10d638
Compare
|
@sfc-gh-xhuang I verified the version is reported correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While constructing HTTP User-Agent header, take the SDK version from code instead from a file on classpath. It is less prone to accidental classpath overrides. The consequence of this is that we must now keep the DEFAULT_VERSION in sync with the project version defined in Maven, which we are doing already anyway (a new test has been added to verify this).