SNOW-928922 send spansMixedTables flag in blob registration requests #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tzhang
approved these changes
Nov 15, 2023
| ParameterProvider.BLOB_FORMAT_VERSION_DEFAULT, | ||
| chunks, | ||
| blobStats, | ||
| chunks == null ? false : chunks.size() > 1); |
There was a problem hiding this comment.
can chunks be null here?
There was a problem hiding this comment.
Yes, because that constructor is used in tests (only) and RegisterServiceTest calls it with chunks null.
| @@ -18,24 +18,33 @@ class BlobMetadata { | |||
| private final Constants.BdecVersion bdecVersion; | |||
| private final List<ChunkMetadata> chunks; | |||
| private final BlobStats blobStats; | |||
| private final boolean spansMixedTables; | |||
There was a problem hiding this comment.
want to add a comment explain this? The name is not straight forward like other fields
There was a problem hiding this comment.
Or I suggest we call it something like hasMultipleTables
There was a problem hiding this comment.
I added a comment.
| @@ -568,8 +568,15 @@ BlobMetadata upload( | |||
| blob.length, | |||
| System.currentTimeMillis() - startTime); | |||
|
|
|||
| // at this point we know for sure if the BDEC file has data for more than one chunk, i.e. | |||
There was a problem hiding this comment.
nit
Suggested change
| // at this point we know for sure if the BDEC file has data for more than one chunk, i.e. | |
| // At this point we know for sure if the BDEC file has data for more than one chunk, i.e. |
Yeah, it will work with old SDKs. The default value server-side if the flag is missing is true. |
sfc-gh-xhuang
approved these changes
Dec 12, 2023
sfc-gh-gdoci
force-pushed
the
gdoci-SNOW-928922-spans-mixed-tables-flag
branch
from
9b53126
to
31612e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new field
spansMixedTablesin BlobMetadata, which is send in the blob registration request.This flag will be used server-side for optimizations and sanity checks.
After this PR, we want to simplify the retry logic so that the new register blob request has all chunks contained in a blob and attempted previously, not just failed chunks.
Both of these will serve the same goal to have correct flag value server-side. The flag is there in case there is something wrong with retries or we have to revert back to old retry logic.
I'll wait for the server-side change to be deployed before merging this PR.