SNOW-1255447: Fix leaked connection due to error response #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-japatel
approved these changes
Mar 21, 2024
| @@ -263,11 +266,12 @@ private static HttpResponse handleExceptionalStatus( | |||
| requestBuilder.addToken(request); | |||
| response = httpClient.execute(request); | |||
| if (!isStatusOK(response.getStatusLine())) { | |||
There was a problem hiding this comment.
Is the if-condition needed here? It looks like we are already inside the same condition (line 247).
There was a problem hiding this comment.
ah, see line 262-265, we refresh the token and retry the request again
sfc-gh-xhuang
approved these changes
Mar 21, 2024
…ingest-java into tzhang-si-threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're leaking HTTP connection when we get an error response from server, and if the client keeps retrying, we will run out connections from the connection pool. This PR contains the change to consume the HTTP response even under error case which will release the connection internally.