Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce OAuth test time #732

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Reduce OAuth test time #732

merged 1 commit into from
Mar 27, 2024

Conversation

sfc-gh-alhuang
Copy link
Contributor

testCreateOAuthClient is taking too much time due to the unnecessary retries in OAuthManager. Remove retries logic when receiving IOException in OAuthManager. As httpClient already retried when getting response code which is not 2xx.

@sfc-gh-alhuang sfc-gh-alhuang marked this pull request as ready for review March 27, 2024 20:00
@sfc-gh-alhuang sfc-gh-alhuang merged commit a1259cc into master Mar 27, 2024
15 checks passed
@sfc-gh-alhuang sfc-gh-alhuang deleted the alhuang-fix-test branch March 27, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants