Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1545879 Reduce the max channel/chunk sizes #796

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

sfc-gh-lsembera
Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera commented Jul 19, 2024

We previously increased the limits 4 times, which turned out to cause OOMs in some cases where memory is limited, so this PR reduces the limits by 1/2, which is still double of the original values.

This PR also fixes a flaky test.

Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfc-gh-xhuang sfc-gh-xhuang merged commit f69259a into master Jul 22, 2024
48 checks passed
@sfc-gh-xhuang sfc-gh-xhuang deleted the lsembera/smaller-chunk-limits branch July 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants