Add six to install_requires. #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
snowdialect.py requires six 1.4.0 or later because it uses six.moves.urllib_parse.unquote_plus.
masamitsu-murase
force-pushed
the
add_six_to_install_requires
branch
from
a0fce8c
to
2d1b6af
Compare
|
I rebased this pull request to resolve conflict with 2bde522. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_requiresin setup.py should include dependency tosixlibrary because snowdialect.py in this library usessix.I added
six>=1.4.0toinstall_requiresin setup.py because snowdialect.py usessix.moves.urllib_parse.unquote_plus, which was introduced insix1.4.0.snowflake-connector-python, which is one of the dependent libraries,
v2.7.7or older depends onsixlibrary indirectly, butv2.7.8does not.As a result, this issue occurs after snowflake-connector-python
v2.7.8was released recently becausesixis not installed automatically when a user runspip install snowflake-sqlalchemy.Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
It seems that any issue has not been submitted yet.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add
"six>=1.4.0"toinstall_requiresin setup.py.