Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 1058245 SqlAlchemy 2.0 support #469

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Snow 1058245 SqlAlchemy 2.0 support #469

wants to merge 15 commits into from

Conversation

sfc-gh-mraba
Copy link
Collaborator

@sfc-gh-mraba sfc-gh-mraba commented Feb 16, 2024 •
edited

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1058245

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
    • I am adding compatibility with SQLAlchemy 2.0

  3. Please describe how your code solves the related issue.

We adapted SnowflakeDialect compatibility with SQLAlchemy 2.0.
We added testing jobs with SQLAlchemy 2.0 installed.
We moved from tox to hatch.

@sfc-gh-mraba sfc-gh-mraba self-assigned this Feb 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-astus
Copy link
Collaborator

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-mraba sfc-gh-mraba changed the title Snow 1058245 sqlalchemy 20 support Snow 1058245 SqlAlchemy 2.0 support Mar 11, 2024
@sfc-gh-astus sfc-gh-astus force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 4af8296 to f1823db Compare March 13, 2024 14:47
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 6f74862 to 5bfa71a Compare March 26, 2024 14:42
@sfc-gh-mraba sfc-gh-mraba marked this pull request as ready for review March 26, 2024 15:37
@sfc-gh-mraba sfc-gh-mraba requested a review from a team March 26, 2024 15:37
sfc-gh-astus
sfc-gh-astus reviewed Mar 28, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@antonrh
Copy link

antonrh commented Apr 12, 2024

🚀

@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch 2 times, most recently from ce3a4c3 to 2d1e343 Compare April 16, 2024 06:40
@nitin-kakkar
Copy link

nitin-kakkar commented Apr 18, 2024 •
edited

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

@nitin-kakkar
Copy link

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

Would really appreciate if you could provide some timeline. Thanks!!

@satniks
Copy link

satniks commented Apr 19, 2024

It looks like implementation is completed and pull request is also approved. Any timelines for merging it and releasing ne version of snowflake-sqlalchemy?

@sjhewitt
Copy link
Contributor

fwiw, I've been running this code in production for a few days and had no issues

@sfc-gh-dszmolka
Copy link

hey folks thank you for the interest; please head to the pinned issue #380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

@sjhewitt appreciate your comment very much, good to hear the changes are running without major issues !

@rafaelclp rafaelclp mentioned this pull request Apr 22, 2024
Open
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 9ff02cc to 553ec0b Compare April 23, 2024 07:12
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 553ec0b to d148282 Compare April 24, 2024 09:38
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from f8d5cfe to ff35809 Compare April 25, 2024 07:21
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from cd98156 to 6a309e6 Compare April 25, 2024 07:46
@nitin-kakkar
Copy link

@sfc-gh-mraba - Is there any update on timelines for merging and releasing new version of snowflake-sqlalchemy?

@sfc-gh-dszmolka
Copy link

@nitin-kakkar please head to the pinned issue #380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

Assignees

@sfc-gh-mraba sfc-gh-mraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sfc-gh-mraba @sfc-gh-astus @antonrh @nitin-kakkar @satniks @sjhewitt @sfc-gh-dszmolka @sfc-gh-pjob