Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1371839] Add regression tests for reported failing pipeline with groupby/qcut #1558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SNOW-1371839] Add regression tests for reported failing pipeline with groupby/qcut #1558

wants to merge 2 commits into from

Conversation

sfc-gh-lspiegelberg
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-1371839

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  2. Please describe how your code solves the related issue.

    Try to reproduce pipeline failure reported, seems to pass with no errors now. Adding tests to avoid future regression.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels May 10, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg marked this pull request as ready for review May 10, 2024 18:50
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg requested a review from a team as a code owner May 10, 2024 18:50
sfc-gh-joshi
sfc-gh-joshi reviewed May 10, 2024
View reviewed changes
tests/integ/modin/test_qcut.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a skipif(running_on_public_ci()) for these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi left review comments

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew was automatically assigned from snowflakedb/snowpandas

@sfc-gh-oplaton sfc-gh-oplaton Awaiting requested review from sfc-gh-oplaton sfc-gh-oplaton was automatically assigned from snowflakedb/snowpandas

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-lspiegelberg @sfc-gh-joshi @sfc-gh-nkrishna