[feature branch] Async session request + hacked up delay to avoid races until we send a response on TCM creation #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-azwiegincew
requested review from
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-yuwang
and removed request for
a team,
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-yuwang
sfc-gh-azwiegincew
changed the title
sfc-gh-oplaton
approved these changes
May 20, 2024
sfc-gh-azwiegincew
merged commit 1446f51
into
server-side-snowpark
13 of 14 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently get a response to the session request. We will need to send one while the query still executes. This will be done when we implement the new REST endpoint. For now, the client just waits a bit to have a good shot at the TCM getting created for subsequent queries.