Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1478406: Avoid unnecessary queries on squeeze #1767

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

sfc-gh-dpetersohn
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1478406

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Avoid unnecessary length query when axis=1

Signed-off-by: Devin Petersohn <devin.petersohn@snowflake.com>
@sfc-gh-dpetersohn sfc-gh-dpetersohn added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jun 12, 2024
@sfc-gh-dpetersohn sfc-gh-dpetersohn requested a review from a team as a code owner June 12, 2024 21:45
@sfc-gh-dpetersohn sfc-gh-dpetersohn added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Jun 12, 2024
Signed-off-by: Devin Petersohn <devin.petersohn@snowflake.com>
Copy link
Contributor

@sfc-gh-nkumar sfc-gh-nkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Out of curiosity is the new code same as OSS modin or we will have upstream this change?

@sfc-gh-dpetersohn
Copy link
Contributor Author

@sfc-gh-nkumar this will need to be contributed back to Modin. Link to Modin ticket: modin-project/modin#7315

Signed-off-by: Devin Petersohn <devin.petersohn@snowflake.com>
@sfc-gh-dpetersohn sfc-gh-dpetersohn merged commit 42ac032 into main Jun 14, 2024
37 checks passed
@sfc-gh-dpetersohn sfc-gh-dpetersohn deleted the devin/1478406 branch June 14, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
@sfc-gh-dpetersohn sfc-gh-dpetersohn restored the devin/1478406 branch June 18, 2024 19:26
@sfc-gh-dpetersohn sfc-gh-dpetersohn deleted the devin/1478406 branch June 18, 2024 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants