[SERVER-SIDE] Add test infrastructure to track all requests have dataframeAST field. #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lspiegelberg
requested review from
sfc-gh-heshah,
sfc-gh-vbudati,
sfc-gh-azwiegincew and
sfc-gh-oplaton
sfc-gh-lspiegelberg
requested review from
sfc-gh-jdu,
sfc-gh-yixie and
sfc-gh-jrose
and removed request for
a team,
sfc-gh-jdu,
sfc-gh-yixie and
sfc-gh-jrose
sfc-gh-azwiegincew
approved these changes
Jun 17, 2024
sfc-gh-lspiegelberg
merged commit 9eef249
into
server-side-snowpark
7 of 8 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors snowflake vcrpy from https://github.com/Snowflake-Labs/snowflake-vcrpy (could not get install working, therefore vendoring it) with custom Snowflake changes to track requests in vendored urllib3 within the snowflake python connector.
Add decorator
check_ast_encode_invoked(applied withautouse=Trueto all tests) which checks that every query send containsdataframeAstproperty for phase 0, and errors out together with traceback information whenever tests need to be fixed / APIs are missing that need to be encoded within the AST.You can skip the
vendoredfolder when reviewing.