Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Customer DataModel and SaveCustomerCommand #15

Merged
merged 6 commits into from Jun 11, 2018

Conversation

nei
Copy link
Member

@nei nei commented May 15, 2018

  • DataModel for m2 Customer, CustomerAddress, RegionData
  • Command for SaveCustomer

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #15 into master will increase coverage by 0.84%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #15      +/-   ##
==========================================
+ Coverage     91.16%    92%   +0.84%     
- Complexity     1978   2277     +299     
==========================================
  Files            71     77       +6     
  Lines          4537   5165     +628     
==========================================
+ Hits           4136   4752     +616     
- Misses          401    413      +12
Impacted Files Coverage Δ Complexity Δ
src/Transform/CreateSaveCustomerCommands.php 0% <0%> (ø) 5 <5> (?)
src/RegionData.php 100% <100%> (ø) 16 <16> (?)
src/CustomerData.php 100% <100%> (ø) 65 <65> (?)
src/Command/SaveCustomerCommand.php 100% <100%> (ø) 7 <7> (?)
src/Order/AddressData.php 100% <100%> (ø) 112 <10> (ø) ⬇️
src/CustomAttributeSet.php 100% <100%> (ø) 8 <2> (+2) ⬆️
src/AddressSet.php 71.42% <71.42%> (ø) 7 <7> (?)
src/CustomerAddress.php 95.3% <95.3%> (ø) 91 <91> (?)
src/Order/PaymentData.php 100% <0%> (ø) 329% <0%> (+105%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d535fa1...e77b78c. Read the comment docs.

@nei nei force-pushed the feature/add-customer-data-model branch from feeff40 to fe1c3f1 Compare May 15, 2018 15:16
@nei nei force-pushed the feature/add-customer-data-model branch from fe1c3f1 to 91e84aa Compare May 15, 2018 15:18
@alexanderwanyoike
Copy link
Contributor

Nice one. Seems cool to me a bit confusing how magento treat ids though.

@nei nei force-pushed the feature/add-customer-data-model branch from 6c47cf3 to 385dc7d Compare June 11, 2018 15:18
@nei nei force-pushed the feature/add-customer-data-model branch from 2314f20 to e77b78c Compare June 11, 2018 15:22
@alexanderwanyoike
Copy link
Contributor

Looks good.

@nei nei merged commit e224800 into master Jun 11, 2018
@nei nei deleted the feature/add-customer-data-model branch June 11, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants