New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Customer DataModel and SaveCustomerCommand #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nei
commented
May 15, 2018
•
edited
edited
- DataModel for m2 Customer, CustomerAddress, RegionData
- Command for SaveCustomer
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 91.16% 92% +0.84%
- Complexity 1978 2277 +299
==========================================
Files 71 77 +6
Lines 4537 5165 +628
==========================================
+ Hits 4136 4752 +616
- Misses 401 413 +12
Continue to review full report at Codecov.
|
nei
force-pushed
the
feature/add-customer-data-model
branch
from
May 15, 2018 15:16
feeff40
to
fe1c3f1
Compare
nei
force-pushed
the
feature/add-customer-data-model
branch
from
May 15, 2018 15:18
fe1c3f1
to
91e84aa
Compare
Nice one. Seems cool to me a bit confusing how magento treat ids though. |
nei
force-pushed
the
feature/add-customer-data-model
branch
from
June 11, 2018 15:18
6c47cf3
to
385dc7d
Compare
nei
force-pushed
the
feature/add-customer-data-model
branch
from
June 11, 2018 15:22
2314f20
to
e77b78c
Compare
Looks good. |
alexanderwanyoike
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.