Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bipartite adjacency maps #207

Merged
merged 22 commits into from Jun 27, 2019

Conversation

@vasalf
Copy link
Contributor

vasalf commented May 31, 2019

No description provided.

vasalf added 10 commits Jun 2, 2019
1. Simplify consistency check for bipartite adjacency maps.
2. Change Bipartite.AdjacencyMap.hasEdge signature to match other Alga
modules.
@snowleopard

This comment has been minimized.

Copy link
Owner

snowleopard commented Jun 11, 2019

@vasalf Many thanks for the PR! I've left a bunch of comments, please have a look.

test/Main.hs Outdated Show resolved Hide resolved
vasalf added 3 commits Jun 22, 2019
@snowleopard

This comment has been minimized.

Copy link
Owner

snowleopard commented Jun 26, 2019

@vasalf There is a test failure:

============ Eq (Bipartite.AdjacencyMap a b) ============
Test failure:
    (x == y) == ((leftAdjacencyMap x == rightAdjacencyMap x) && (leftAdjacencyMap y == rightAdjacencyMap y))
*** Failed! Falsified (after 3 tests):
empty
vertices [-2] [-2]

The full log is here: https://travis-ci.org/snowleopard/alga/jobs/550349421

Please investigate.

@vasalf

This comment has been minimized.

Copy link
Contributor Author

vasalf commented Jun 26, 2019

@vasalf There is a test failure:

============ Eq (Bipartite.AdjacencyMap a b) ============
Test failure:
    (x == y) == ((leftAdjacencyMap x == rightAdjacencyMap x) && (leftAdjacencyMap y == rightAdjacencyMap y))
*** Failed! Falsified (after 3 tests):
empty
vertices [-2] [-2]

The full log is here: https://travis-ci.org/snowleopard/alga/jobs/550349421

Please investigate.

@snowleopard Thanks for pointing it out! It turned out that the test was wrong. I fixed it. Hope it will pass this time (it passes on my machine, but we know that means nothing).

I also fixed a small bug in Show instance.

@snowleopard snowleopard merged commit 7c43d08 into snowleopard:master Jun 27, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snowleopard

This comment has been minimized.

Copy link
Owner

snowleopard commented Jun 27, 2019

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.