Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health status reporter to the Source interface #40

Closed
istreeter opened this issue Nov 28, 2023 · 0 comments
Closed

Add health status reporter to the Source interface #40

istreeter opened this issue Nov 28, 2023 · 0 comments

Comments

@istreeter
Copy link
Contributor

Currently, Snowplow apps using this library have no way of knowing....

  • For Pubsub, when has the Subscriber successfully connected
  • For Kafka, when have we connected and (more importantly!) when are we in the middle of rebalancing
  • (We also know nothing about Kinesis health status, but this is more difficult to fix)

We can add a method to SourceAndAck so it reports its health status. In doing so, we can remove the old processingLatency method, so to keep the interface as simple as possible.
istreeter added a commit that referenced this issue Nov 28, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
c239c9d
istreeter added a commit that referenced this issue Nov 28, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
f854dba
istreeter added a commit that referenced this issue Nov 29, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
b491fca
istreeter added a commit that referenced this issue Nov 29, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
e2c3afe
istreeter added a commit that referenced this issue Dec 4, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
ec72d56
istreeter added a commit that referenced this issue Dec 4, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
f7aa155
istreeter added a commit that referenced this issue Dec 5, 2023
@istreeter
Add health status reporter to the Source interface (close #40)
17a8447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@istreeter