Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EnrichmentManager.enrichEvent to validate events #23

Closed
benjben opened this issue May 15, 2020 · 0 comments
Closed

Use EnrichmentManager.enrichEvent to validate events #23

benjben opened this issue May 15, 2020 · 0 comments
Assignees
@benjben
Milestone
Release/1.0.0

Comments

@benjben
Copy link
Contributor

benjben commented May 15, 2020

2 added values:

  • Remove the manual steps to extract input contexts and enriched events, base64 encoded or not
  • Have more strict validation. With snowplow-micro 0.1.0 it was possible that an event validated by Micro would fail being enriched because of an invalid input field (e.g. timestamp). When using EnrichmentManager.enrichEvent to validate the event, we know that an event that gets validated by Micro will not break the enrichment

Taking the opportunity to return the EnrichedEvent as well as the RawEvent
@benjben benjben added this to the Release/1.0.0 milestone May 15, 2020
This was referenced May 15, 2020
Closed
Closed
benjben added a commit that referenced this issue May 17, 2020
@benjben
[WIP] Use EnrichmentManager.enrichEvent to validate events (close #23)
57a63a0
benjben added a commit that referenced this issue Jun 26, 2020
@benjben
[WIP] Use EnrichmentManager.enrichEvent to validate events (close #23)
aa0f21f
benjben added a commit that referenced this issue Jul 24, 2020
@benjben
Use EnrichmentManager.enrichEvent to validate events (close #23)
b2c70d5
@benjben benjben self-assigned this Jul 24, 2020
benjben added a commit that referenced this issue Jul 24, 2020
@benjben
Use EnrichmentManager.enrichEvent to validate events (close #23)
5c5a02a
istreeter pushed a commit that referenced this issue Jul 29, 2020
@benjben
Use EnrichmentManager.enrichEvent to validate events (close #23)
2a5ef94
istreeter pushed a commit that referenced this issue Jul 29, 2020
@benjben
Use EnrichmentManager.enrichEvent to validate events (close #23)
4aff2d3
istreeter pushed a commit that referenced this issue Jul 29, 2020
@benjben
Use EnrichmentManager.enrichEvent to validate events (close #23)
6c3cb7f
istreeter pushed a commit that referenced this issue Sep 10, 2020
@benjben
Use EnrichmentManager.enrichEvent to validate events (close #23)
f62c5d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjben benjben

Labels
None yet
Projects
None yet
Milestone
Release/1.0.0
Development

No branches or pull requests
1 participant
@benjben